ABSTRACT Much of teacher feedback research is conducted in the L1 and L2 contexts. There is a paucity of research about feedback in the Teaching Chinese as a Foreign Language (TCFL) context. Particularly, little is known about teachers' feedback practices and student views of teacher feedback. The present study was undertaken to fill the research gap by focusing on teachers'written feedback. Student data from surveying 38 students was interpreted with teacher data gained from interviewing three teachers. The findings indicate that teacher written feedback, which occurred in a multiple-draft writing cycle, generally accorded with recommended feedback principles. Students responded favorably to teacher written feedback. The results also reveal discrepancies between teachers' feedback practices and student perceptions of and preferences regarding teacher feedback. The results show that students wanted more written comments from teachers, though most teachers didn't prioritize written comments. Despite teachers' practices and their inclination toward offering coded indirect error correction, students in the study expressed their preferences for direct error correction. Most students are interested in receiving teacher feedback that addresses all aspects of writing rather than primarily focusing on language accuracy. The reasons that may account for the disjuncture are also discussed in the study. The study concludes that it is important for teachers to be aware of student attitudes and expectations regarding teacher feedback. Teachers should be flexible enough to provide individualized feedback. Pedagogical implications are included in the paper in the hope of shedding light on the development of effective and helpful teacher feedback.